Repository navigation
feat: rotate meeting join links - WPB-28499 - #5468
Conversation
|
Please make sure new localizations are translated once merged to develop. New strings (English):
|
![semgrep-code-wireapp[bot]](https://avatars.githubusercontent.com/u/16047324?s=60&v=4){kind=small}
Test Results 4 files 255 suites 2m 28s ⏱️ Results for commit c3a50b3. ♻️ This comment has been updated with latest results. Summary: workflow run #41460822582 |
caldrian
left a comment
caldrian
left a comment
There was a problem hiding this comment.
Reviewed the link-rotation API/repository wiring, password validation, duplicate-request protection, and stale-fetch handling. The WireCalling tests pass in CI, but WireDomainTests fails to compile because two handwritten MeetingsAPI doubles were not updated. The failure is directly caused by the new protocol requirement and needs fixing before approval. CI evidence: https://github.com/wireapp/wire-ios/actions/runs/40570494853/job/122423898943 . I did not rerun the full test suite locally.
caldrian
left a comment
caldrian
left a comment
There was a problem hiding this comment.
Reviewed c2debdb, including the v19 refresh request and response against the backend contract, repository mapping, both entry points, password validation, duplicate-request protection, stale-fetch handling, and the sheet changes. No new actionable findings.
The previously reported MeetingsAPI conformance issue is addressed in both handwritten notification test doubles. The current CI checks pass. This review is based on source inspection and existing CI results; I did not run the app or tests locally.
Issue
Meeting owners can replace a join link from Meeting link or Edit meeting, with an optional replacement password.
The form uses the standard Meetings password and confirmation controls. The link viewer fits its content and supports large-text scrolling.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: